[Merged by Bors] - Fix torus normals #3549
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice work! The greyness is (i think) an expected effect from highly reflective surfaces (notice a similar effect at the bottom of the red sphere in this Filament render). Increasing the perceptual_roughness should make it go away. Shadow artifacts are hard to avoid in all cases. That will be a constant battle I think 😄 |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jan 4, 2022
# Objective Fixes #3547 ## Solution Normal calc adapted from https://web.cs.ucdavis.edu/~amenta/s12/findnorm.pdf ## Before <img width="1392" alt="before" src="https://user-images.githubusercontent.com/200550/148125212-fb1c083e-3c57-4330-a656-df34513c36ab.png"> ## After <img width="1392" alt="after" src="https://user-images.githubusercontent.com/200550/148125223-174dc956-37df-4ac2-8983-b18e1e2a9a7d.png"> I'm assuming that the greyness and the self-shadowing artifacts are... normal for the new renderer.
alice-i-cecile
added
A-Rendering
|
Nice work, thanks! |
|
Very cool, thanks! |
|
The artifacts in the shadow are likely due to the resolution of the shadow map - notice the pixelation in the shadows. For example, here's what a torus looks like in my app (using the new renderer):
|
bors bot
pushed a commit
that referenced
this pull request
Apr 26, 2022
# Objective Fix wonky torus normals. ## Solution I attempted this previously in #3549, but it looks like I botched it. It seems like I mixed up the y/z axes. Somehow, the result looked okay from that particular camera angle. This video shows toruses generated with - [left, orange] original torus mesh code - [middle, pink] PR 3549 - [right, purple] This PR https://user-images.githubusercontent.com/200550/164093183-58a7647c-b436-4512-99cd-cf3b705cefb0.mov
exjam
pushed a commit
to exjam/bevy
that referenced
this pull request
May 22, 2022
# Objective Fix wonky torus normals. ## Solution I attempted this previously in bevyengine#3549, but it looks like I botched it. It seems like I mixed up the y/z axes. Somehow, the result looked okay from that particular camera angle. This video shows toruses generated with - [left, orange] original torus mesh code - [middle, pink] PR 3549 - [right, purple] This PR https://user-images.githubusercontent.com/200550/164093183-58a7647c-b436-4512-99cd-cf3b705cefb0.mov
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective Fix wonky torus normals. ## Solution I attempted this previously in bevyengine#3549, but it looks like I botched it. It seems like I mixed up the y/z axes. Somehow, the result looked okay from that particular camera angle. This video shows toruses generated with - [left, orange] original torus mesh code - [middle, pink] PR 3549 - [right, purple] This PR https://user-images.githubusercontent.com/200550/164093183-58a7647c-b436-4512-99cd-cf3b705cefb0.mov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #3547
Solution
Normal calc adapted from https://web.cs.ucdavis.edu/~amenta/s12/findnorm.pdf
Before
After
I'm assuming that the greyness and the self-shadowing artifacts are... normal for the new renderer.